Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix windows build issue #847

Merged
merged 1 commit into from
May 21, 2024
Merged

chore: fix windows build issue #847

merged 1 commit into from
May 21, 2024

Conversation

phani-srikar
Copy link
Contributor

Description of changes

Move the postinstall script to be run as part of deprecate workflow where it is needed.
This was causing issues in windows environments where the script is not being executed as part of postinstall action.
image
Verified that the contents of the script or execute permissions aren't the issue.

Codegen Paramaters Changed or Added

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • Breaking changes to existing customers are released behind a feature flag or major version update
  • Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified
  • Changes are tested on windows. Some Node functions (such as path) behave differently on windows.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phani-srikar phani-srikar requested review from a team as code owners May 21, 2024 17:48
@phani-srikar phani-srikar merged commit 45c26d9 into main May 21, 2024
4 checks passed
@dpilch dpilch deleted the fix-windows-build branch May 22, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants